Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/13796#discussion_r74832879
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -930,10 +942,8 @@ class BinaryLogisticRegressionSummary
private[classification] (
}
/**
- * LogisticAggregator computes the gradient and loss for binary logistic
loss function, as used
- * in binary classification for instances in sparse or dense vector in an
online fashion.
- *
- * Note that multinomial logistic loss is not supported yet!
+ * LogisticAggregator computes the gradient and loss for binary or
multinomial logistic loss
--- End diff --
I agree we have a lot of code in a single file, though linear regression
suffers from the same problem. I don't feel too strongly one way or the other.
Do you have a specific package location in mind?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
