Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1545#discussion_r16388372
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -1029,6 +1033,7 @@ class DAGScheduler(
           case FetchFailed(bmAddress, shuffleId, mapId, reduceId) =>
             // Mark the stage that the reducer was in as unrunnable
             val failedStage = stageIdToStage(task.stageId)
    +        listenerBus.post(SparkListenerStageCompleted(failedStage.info))
    --- End diff --
    
    Does it make sense to just call markStageAsFinished here (instead of the 
two lines above)?  I just wonder if doing that will help avoid future bugs 
along this code path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to