Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1545#discussion_r16389097
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
    @@ -43,13 +43,16 @@ class JobProgressListener(conf: SparkConf) extends 
SparkListener with Logging {
       // How many stages to remember
       val retainedStages = conf.getInt("spark.ui.retainedStages", 
DEFAULT_RETAINED_STAGES)
     
    -  val activeStages = HashMap[Int, StageInfo]()
    +  // Map from stageId to StageInfo
    +  val activeStages = new HashMap[Int, StageInfo]
    +
    +  // Map from (stageId, attemptId) to StageInfo
    +  val stageIdToData = new HashMap[(Int, Int), StageUIData]
    +
       val completedStages = ListBuffer[StageInfo]()
       val failedStages = ListBuffer[StageInfo]()
     
    -  val stageIdToData = new HashMap[Int, StageUIData]
    -
    -  val poolToActiveStages = HashMap[String, HashMap[Int, StageInfo]]()
    +  val poolToActiveStages = HashMap[String, HashMap[(Int, Int), 
StageInfo]]()
    --- End diff --
    
    why do you need to index this by attempt + stageID? As above, isn't only 
one attempt active at once?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to