Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1845#discussion_r16396219
--- Diff: bin/spark-submit ---
@@ -36,9 +38,27 @@ while (($#)); do
done
DEPLOY_MODE=${DEPLOY_MODE:-"client"}
+DEFAULT_PROPERTIES_FILE="$SPARK_HOME/conf/spark-defaults.conf"
+PROPERTIES_FILE=${PROPERTIES_FILE:-"$DEFAULT_PROPERTIES_FILE"}
-if [ -n "$DRIVER_MEMORY" ] && [ $DEPLOY_MODE == "client" ]; then
- export SPARK_DRIVER_MEMORY=$DRIVER_MEMORY
+# For client mode, the driver will be launched in the same JVM that
launches
+# SparkSubmit, so we may need to read the properties file for any extra
class
+# paths, library paths, java options and memory early on. Otherwise, it
will
+# be too late by the time the JVM has started.
+
+if [ "$DEPLOY_MODE" == "client" ]; then
--- End diff --
These script changes seem simple enough that it makes sense to port them to
windows in the same patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
