Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1845#discussion_r16397290
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkClassLauncher.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.deploy
+
+import java.io.File
+
+import scala.collection.JavaConversions._
+
+import org.apache.spark.util.{RedirectThread, Utils}
+
+/**
+ * Wrapper of `bin/spark-class` that prepares the launch environment of
the child JVM properly.
+ * This is currently only used for running Spark submit in client mode.
The goal moving forward
+ * is to use this class for all use cases of `bin/spark-class`.
+ */
+object SparkClassLauncher {
+
+ /**
+ * Launch a Spark class with the given class paths, library paths, java
options and memory.
+ * If we are launching an application through Spark submit in client
mode, we must also
+ * take into account special `spark.driver.*` properties needed to start
the driver JVM.
+ */
+ def main(args: Array[String]): Unit = {
+ if (args.size < 8) {
+ System.err.println(
+ """
+ |Usage: org.apache.spark.deploy.SparkClassLauncher
--- End diff --
To keep it simpler for now, rather than having a bunch of command line
arguments, why not just directly read the environment variables set in
`spark-class`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
