Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14674#discussion_r75444301
  
    --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
    @@ -282,6 +282,9 @@ private[spark] class SecurityManager(sparkConf: 
SparkConf)
           }: TrustManager
         })
     
    +    require(fileServerSSLOptions.protocol.isDefined,
    +      "spark.ssl.protocol is required when enabling SSL connections.")
    +
         val sslContext = 
SSLContext.getInstance(fileServerSSLOptions.protocol.getOrElse("Default"))
    --- End diff --
    
    OK, though "getOrElse" is redundant now. "Default" is a meaningless value 
and I thought that was what the JIRA wanted to also remove.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to