Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/14547#discussion_r75523809
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -258,11 +258,13 @@ private[spark] object GradientBoostedTrees extends
Logging {
val baseLearnerWeights = new Array[Double](numIterations)
val loss = boostingStrategy.loss
val learningRate = boostingStrategy.learningRate
- // Prepare strategy for individual trees, which use regression with
variance impurity.
+ // Prepare strategy for individual trees, which all use regression.
+ // TODO(vlad17): Changing the strategy here is confusing (especially
using regression for
--- End diff --
Anywhere you need to leave a TODO, it'd be good to create a corresponding
JIRA to fix it, where that JIRA is linked as blocked by this current JIRA.
Here, you could just use ```TODO(SPARK-16728)```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
