Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/14547#discussion_r75523805
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/DTStatsAggregator.scala ---
@@ -33,11 +34,13 @@ private[spark] class DTStatsAggregator(
/**
* [[ImpurityAggregator]] instance specifying the impurity type.
- */
- val impurityAggregator: ImpurityAggregator = metadata.impurity match {
+ */
+ private val impurityAggregator: ImpurityAggregator = metadata.impurity
match {
+ // TODO(vlad17): this is a ridiculous coupling. Impurity should have a
getAggregator() method
--- End diff --
It should, but it should not have a getAggregator() method which returns a
class from spark.mllib. getAggregator should be put inside Impurity after
spark.ml has the necessary class---but that need should be documented here.
Can you please create a JIRA to fix this and modify your comment here to
link to the new JIRA? I'd also note in the JIRA that we should consider not
having Aggregator classes in spark.ml at all since that functionality could
live inside Impurity classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
