Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14712#discussion_r75603123
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala
 ---
    @@ -72,9 +72,12 @@ case class LogicalRelation(
       // expId can be different but the relation is still the same.
       override lazy val cleanArgs: Seq[Any] = Seq(relation)
     
    -  @transient override lazy val statistics: Statistics = Statistics(
    -    sizeInBytes = BigInt(relation.sizeInBytes)
    -  )
    +  // statistics inherited from a MetastoreRelation
    +  @transient var inheritedStats: Option[Statistics] = None
    --- End diff --
    
    @cloud-fan should `BaseRelation` in a perfect world contain a statistics 
object? That would have my preference, if we can maintain binary compatibility 
(mainly for the many connectors that use this API).
    
    +1 for moving table conversion into the planner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to