Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14712#discussion_r75588230
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala
 ---
    @@ -33,7 +34,7 @@ import 
org.apache.spark.sql.catalyst.catalog.{CatalogRelation, CatalogTable}
      * Right now, it only supports Hive tables and it only updates the size of 
a Hive table
      * in the Hive metastore.
      */
    -case class AnalyzeTableCommand(tableName: String) extends RunnableCommand {
    +case class AnalyzeTableCommand(tableName: String, noscan: Boolean = true) 
extends RunnableCommand {
     
       override def run(sparkSession: SparkSession): Seq[Row] = {
    --- End diff --
    
    Not related to this PR, but looks like `AnalyzeTableCommand` doesn't handle 
the possible `NoSuchTableException` caused by 
`sessionState.catalog.lookupRelation`. It should be better to handle it and 
provide error message. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to