Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/14747#discussion_r75636343
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -114,7 +114,7 @@ final class QuantileDiscretizer @Since("1.6.0")
(@Since("1.6.0") override val ui
splits(0) = Double.NegativeInfinity
splits(splits.length - 1) = Double.PositiveInfinity
- val bucketizer = new Bucketizer(uid).setSplits(splits)
+ val bucketizer = new Bucketizer(uid).setSplits(splits.distinct.sorted)
--- End diff --
I'm more prefer to leave warning log for this condition. Since if users set
```numBuckets = 10```, and then get buckets with less than the
```numBuckets```, it will confuse users. What about your thoughts? @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
