Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14747#discussion_r75643772
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -114,7 +114,11 @@ final class QuantileDiscretizer @Since("1.6.0")
(@Since("1.6.0") override val ui
splits(0) = Double.NegativeInfinity
splits(splits.length - 1) = Double.PositiveInfinity
- val bucketizer = new Bucketizer(uid).setSplits(splits)
+ val cutpoints = splits.distinct
+ if(splits.length != cutpoints.length) {
--- End diff --
Nit: space after "if". Also this could state the number of resulting
buckets, since it definitely will happen:
`log.warn(s"Some quantiles were identical. Bucketing to ${splits.length -
1} buckets as a result.")`
Finally, please update the title of the PR to match the JIRA, which is more
descriptive as a commit log message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
