Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/2038#discussion_r16436111
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -91,12 +91,30 @@ class NaiveBayes private (private var lambda: Double)
extends Serializable with
* @param data RDD of [[org.apache.spark.mllib.regression.LabeledPoint]].
*/
def run(data: RDD[LabeledPoint]) = {
+ val requireNonnegativeValues: Vector => Unit = (v: Vector) => {
+ val values = v match {
+ case sv: SparseVector =>
+ sv.values
+ case dv: DenseVector =>
+ dv.values
+ }
+ if (!values.forall(x => x >= 0.0)) {
--- End diff --
Could shorten:
if (!values.forall(_ >= 0.0)) {
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
