Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/2038#issuecomment-52683940
LGTM. The function requireNonnegativeValues() actually also identifies NaN
values, so you could add a test in the Suite for that. (Same as the
test("detect negative values") but with -1.0 replaced with 0.0/0.0)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
