Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14698#discussion_r76176582
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -474,6 +474,20 @@ case class MapObjects private(
s"$seq == null ? $array[$loopIndex] : $seq.apply($loopIndex)"
}
+ // Make a copy of the data if it's unsafe-backed
+ val genFunctionValue = lambdaFunction.dataType match {
--- End diff --
we're calling `toString` on a `UTF8String`, so maybe there's no need to
clone `UTF8String`s?
```java
...
/* 072 */ value8 = MapObjects_loopValue2.getUTF8String(0);
...
/* 082 */ funcResult = value8.toString();
...
/* 086 */ value7 = (java.lang.String) funcResult;
...
/* 128 */ convertedArray[loopIndex] = ...;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
