GitHub user tejasapatil opened a pull request:
https://github.com/apache/spark/pull/14841
[SPARK-17271] [SQL] Planner adds un-necessary Sort even if child ordering
is semantically same as required ordering
## What changes were proposed in this pull request?
Jira : https://issues.apache.org/jira/browse/SPARK-17271
This PR includes following changes:
- Added a `semanticEquals` method to `SortOrder` so that it can compare
underlying child expressions semantically (and not using default Object.equals)
- Fixed `EnsureRequirements` to use semantic comparison of SortOrder
## How was this patch tested?
- Added a test case to `PlannerSuite`. Ran rest tests in `PlannerSuite`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tejasapatil/spark
SPARK-17271_sort_order_equals_bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14841.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14841
----
commit 7192418b3a26a14642fc04fc92bf496a954ffa5d
Author: Tejas Patil <tej...@fb.com>
Date: 2016-08-27T02:59:28Z
[SPARK-17271] [SQL] Planner adds un-necessary Sort even if child ordering
is semantically same as required ordering
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
