Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14841#discussion_r77114998
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -61,6 +61,9 @@ case class SortOrder(child: Expression, direction:
SortDirection)
override def sql: String = child.sql + " " + direction.sql
def isAscending: Boolean = direction == Ascending
+
+ def semanticEquals(other: SortOrder): Boolean =
--- End diff --
yea I understand in `EnsureRequirements` we should use `semanticEquals`
instead of `==` to compare `SortOrder`, but why we need to implement
`samanticEquals` again in `SortOrder`? What's wrong with the default
implementation?
I mean, there is no need to "introduce" a `semanticEquals` in `SortOrder`,
it already has.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
