Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77067766
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -698,6 +698,8 @@ private[sql] class SQLConf extends Serializable with
CatalystConf with Logging {
override def orderByOrdinal: Boolean = getConf(ORDER_BY_ORDINAL)
override def groupByOrdinal: Boolean = getConf(GROUP_BY_ORDINAL)
+
+ override def allowCartesianProduct: Boolean =
getConf(CROSS_JOINS_ENABLED)
--- End diff --
As discussed, I only have the crossJoinEnabled flag, which has been exposed
in CatalystConf. Also as discussed, deprecating crossJoinEnabled and switching
the conf flag to requireCrossJoinSyntax is a good idea, will address in a
follow-up PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
