Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77089271
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -39,39 +38,46 @@ object ReorderJoin extends Rule[LogicalPlan] with
PredicateHelper {
*
* The joined plan are picked from left to right, prefer those has at
least one join condition.
*
- * @param input a list of LogicalPlans to join.
+ * @param input a list of LogicalPlans to inner join and the type of
inner join.
* @param conditions a list of condition for join.
*/
@tailrec
- def createOrderedJoin(input: Seq[LogicalPlan], conditions:
Seq[Expression]): LogicalPlan = {
+ def createOrderedJoin(input: Seq[(LogicalPlan, InnerLike)], conditions:
Seq[Expression])
+ : LogicalPlan = {
assert(input.size >= 2)
if (input.size == 2) {
--- End diff --
using a pattern match might be simpler here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
