Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/14841#discussion_r77117090
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -61,6 +61,9 @@ case class SortOrder(child: Expression, direction:
SortDirection)
override def sql: String = child.sql + " " + direction.sql
def isAscending: Boolean = direction == Ascending
+
+ def semanticEquals(other: SortOrder): Boolean =
--- End diff --
@cloud-fan : I see what you were trying to say before. I tried that and it
worked. I have created a PR to clean it up :
https://github.com/apache/spark/pull/14910 Thanks for pointing this out !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
