Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77142563
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1204,9 +1204,29 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef]
with Logging {
*/
override def visitSortItem(ctx: SortItemContext): SortOrder =
withOrigin(ctx) {
if (ctx.DESC != null) {
--- End diff --
the code below can be a lot shorter.
```scala
val direction = if (ctx.DESC != null) {
Descending
} else {
Ascending
}
val nullOrdering = if (ctx.FIRST != null) {
NullFirst
} else if (ctx.LAST != null) {
NullLast
} else {
direction.defaultNullOrdering
}
SortOrder(expression(ctx.expression), direction, nullOrdering)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
