Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14842#discussion_r77210917
  
    --- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
    @@ -324,7 +324,7 @@ queryPrimary
         ;
     
     sortItem
    -    : expression ordering=(ASC | DESC)?
    +    : expression ordering=(ASC | DESC)? (NULLS nullOrder=(LAST | FIRST))?
    --- End diff --
    
    I am sorry, that is a typo. I was asking if we should support a null 
ordering clause without defining the sort order. I am fine with that, but I 
have been wrong before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to