Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77221863
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -40,23 +41,37 @@ class RadixSortSuite extends SparkFunSuite with Logging
{
case class RadixSortType(
name: String,
referenceComparator: PrefixComparator,
- startByteIdx: Int, endByteIdx: Int, descending: Boolean, signed:
Boolean)
+ startByteIdx: Int, endByteIdx: Int, descending: Boolean, signed:
Boolean, nullFirst: Boolean)
--- End diff --
Could you also add null ordering tests to `SortSuite.scala`? That's a more
comprehensive randomized test suite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
