Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77241547
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -69,6 +71,29 @@ private[sql] class SharedState(val sparkContext:
SparkContext) extends Logging {
val jarClassLoader = new NonClosableMutableURLClassLoader(
org.apache.spark.util.Utils.getContextOrSparkClassLoader)
+ /**
+ * Add a global-scoped jar
+ */
+ def addJar(path: String): Unit = {
+ if (sparkContext.conf.get(CATALOG_IMPLEMENTATION) == "hive") {
+ // Hive metastore supports custom serde.
+ externalCatalog.addJar(path)
--- End diff --
Also used by run-time function loading when Hive support is enabled.
If Hive support is not enabled, `ADD JAR` is the only caller of
`SharedState.addJar`. It is just a SQL interface of `sparkContext.addJar`. I am
not sure whether end users are using `ADD JAR` for `sparkContext.addJar`. Thus,
I am hesitant to make any external behavior change in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
