Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14922#discussion_r77318912
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
    @@ -405,5 +405,9 @@ private[ml] trait HasAggregationDepth extends Params {
     
       /** @group expertGetParam */
       final def getAggregationDepth: Int = $(aggregationDepth)
    +
    +  def getAggregationDepthByFormula(driverMemory: Long, dimension: Int, 
partitionNum: Int): Int = {
    +    if (dimension > 200) 2 else 1
    --- End diff --
    
    Can you explain this formula? I'm still not sure what the logic of this 
change is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to