Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14922#discussion_r77357109
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -295,6 +295,13 @@ class LogisticRegression @Since("1.2.0") (
instr.logParams(regParam, elasticNetParam, standardization, threshold,
maxIter, tol, fitIntercept)
+ val autoAggregationDepth =
+ if ($(aggregationDepth) > 0) $(aggregationDepth)
+ else getAggregationDepthByFormula(
+ instances.context.getConf.getSizeAsBytes("spark.driver.memory",
"1g"),
--- End diff --
Yes I know. The problem is you've duplicated the default here. Would it
ever not be set at this point? the driver had to have set some amount of memory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
