Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r77424940
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -222,10 +245,19 @@ case class AlterViewAsCommand(
qe.assertAnalyzed()
val analyzedPlan = qe.analyzed
- if (session.sessionState.catalog.isTemporaryTable(name)) {
- session.sessionState.catalog.createTempView(name.table,
analyzedPlan, overrideIfExists = true)
- } else {
+ if (name.database.isDefined) {
alterPermanentView(session, analyzedPlan)
+ } else if (session.sessionState.catalog.isTemporaryTable(name)) {
--- End diff --
Shouldn't we check the current database for the view name ? Or do we assume
that database is resolved into the tableidentifier ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
