Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/14976#discussion_r77735611
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/QuantileSummaries.scala
---
@@ -236,7 +240,7 @@ object QuantileSummaries {
if (currentSamples.isEmpty) {
return Array.empty[Stats]
}
- val res: ArrayBuffer[Stats] = ArrayBuffer.empty
+ val res = ListBuffer.empty[Stats]
--- End diff --
Ah, thanks, I thought it was smart enough to use a circular buffer, thanks!
It would be nice to have more control over the memory eventually, but this is
fine for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
