Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14976#discussion_r77780355
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/QuantileSummaries.scala
---
@@ -59,9 +59,14 @@ class QuantileSummaries(
* @param x the new observation to insert into the summary
*/
def insert(x: Double): QuantileSummaries = {
- headSampled.append(x)
+ headSampled += x
if (headSampled.size >= defaultHeadSize) {
- this.withHeadBufferInserted
+ val result = this.withHeadBufferInserted
+ if (result.sampled.length >= compressThreshold) {
+ result.compress()
--- End diff --
@clockfly oh, hm, this code just landed recently? it seems to call
`compress()` itself rather than leave it to `QuantileSummaries`, in which case
I'm not clear why there's a `compressThreshold` in `QuantileSummaries` It seems
like the new class is trying to manage it. What's the right way to rationalize
this -- are you saying `QuantileSummaries` shouldn't manage compression at all?
that's fine too (in which case this can just turn into a very small
optimization change).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
