Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14969#discussion_r78273942
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsTab.scala
---
@@ -87,19 +110,31 @@ class ExecutorsListener(storageStatusListener:
StorageStatusListener, conf: Spar
s.blockManagerId.executorId ==
SparkContext.LEGACY_DRIVER_IDENTIFIER ||
s.blockManagerId.executorId == SparkContext.DRIVER_IDENTIFIER
}
- storageStatus.foreach { s =>
executorToLogUrls(s.blockManagerId.executorId) = logs.toMap }
+ storageStatus.foreach { s =>
+ val eid = s.blockManagerId.executorId
+ if (!executorToTaskSummary.contains(eid)) {
--- End diff --
Hm, and while we're at it, maybe these blocks that check if a key has a
mapping and otherwise add a new value can use `getOrElseUpdate`? it might only
work if `ExecutorTaskSummary` does not need the "executorId" field, but does it
need that? it's kind of redundant since it's always looked up by key. Not sure,
maybe I missed something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
