Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14969#discussion_r78351548
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsTab.scala 
---
    @@ -38,47 +37,68 @@ private[ui] class ExecutorsTab(parent: SparkUI) extends 
SparkUITab(parent, "exec
       }
     }
     
    +private[ui] case class ExecutorTaskSummary(
    +    var executorId: String,
    +    var totalCores: Int = 0,
    +    var tasksMax: Int = 0,
    +    var tasksActive: Int = 0,
    +    var tasksFailed: Int = 0,
    +    var tasksComplete: Int = 0,
    +    var duration: Long = 0L,
    +    var jvmGCTime: Long = 0L,
    +    var inputBytes: Long = 0L,
    +    var inputRecords: Long = 0L,
    +    var outputBytes: Long = 0L,
    +    var outputRecords: Long = 0L,
    +    var shuffleRead: Long = 0L,
    +    var shuffleWrite: Long = 0L,
    +    var executorLogs: Map[String, String] = Map.empty,
    +    var isAlive: Boolean = true
    +)
    +
     /**
      * :: DeveloperApi ::
      * A SparkListener that prepares information to be displayed on the 
ExecutorsTab
      */
     @DeveloperApi
     class ExecutorsListener(storageStatusListener: StorageStatusListener, 
conf: SparkConf)
         extends SparkListener {
    -  val executorToTotalCores = HashMap[String, Int]()
    -  val executorToTasksMax = HashMap[String, Int]()
    -  val executorToTasksActive = HashMap[String, Int]()
    -  val executorToTasksComplete = HashMap[String, Int]()
    -  val executorToTasksFailed = HashMap[String, Int]()
    -  val executorToDuration = HashMap[String, Long]()
    -  val executorToJvmGCTime = HashMap[String, Long]()
    -  val executorToInputBytes = HashMap[String, Long]()
    -  val executorToInputRecords = HashMap[String, Long]()
    -  val executorToOutputBytes = HashMap[String, Long]()
    -  val executorToOutputRecords = HashMap[String, Long]()
    -  val executorToShuffleRead = HashMap[String, Long]()
    -  val executorToShuffleWrite = HashMap[String, Long]()
    -  val executorToLogUrls = HashMap[String, Map[String, String]]()
    -  val executorIdToData = HashMap[String, ExecutorUIData]()
    +  var executorToTaskSummary = LinkedHashMap[String, ExecutorTaskSummary]()
    +  var executorEvents = new ListBuffer[SparkListenerEvent]()
    +
    +  private val maxTimelineExecutors = 
conf.getInt("spark.ui.timeline.executors.maximum", 1000)
    --- End diff --
    
    Getting close now, but what about spark.ui.timeline.retainedExecutors? that 
would be more consistent. Then what about 
spark.ui.timeline.retainedDeadExecutors?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to