Github user klueska commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14644#discussion_r78297397
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
 ---
    @@ -103,6 +103,7 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
       private val stateLock = new ReentrantLock
     
       val extraCoresPerExecutor = conf.getInt("spark.mesos.extra.cores", 0)
    +  val maxGpus = conf.getInt("spark.mesos.gpus.max", 0)
    --- End diff --
    
    I just looked up what the semantics of "cores.max" are and they seem to be 
slightly different than what this patch includes:
    http://spark.apache.org/docs/latest/running-on-mesos.html#coarse-grained
    
    It says that if "cores.max" is not included, then spark will just blindly 
accept all cpu offers it is given. In the current patch, *no* gpu resources 
will be accepted if "gpus.max" is not set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to