Github user tnachen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14644#discussion_r78298417
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
 ---
    @@ -103,6 +103,7 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
       private val stateLock = new ReentrantLock
     
       val extraCoresPerExecutor = conf.getInt("spark.mesos.extra.cores", 0)
    +  val maxGpus = conf.getInt("spark.mesos.gpus.max", 0)
    --- End diff --
    
    Which sounds sensible to me since GPU is not usually required to run your 
Spark job. And also cores.max is an aggregate max, where gpu.max as the current 
patch is a per node max. I think I will change this into how cores.max work, 
but default to 0. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to