Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15058#discussion_r78356812
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetrics.scala
---
@@ -43,10 +43,13 @@ import org.apache.spark.sql.DataFrame
@Since("1.0.0")
class BinaryClassificationMetrics @Since("1.3.0") (
@Since("1.3.0") val scoreAndLabels: RDD[(Double, Double)],
- @Since("1.3.0") val numBins: Int) extends Logging {
+ @Since("1.3.0") var numBins: Int) extends Logging {
--- End diff --
It looks like a typo in the comment, and intends to refer to the calling
class. See
https://github.com/mpjlu/spark/commit/c5c6aded641048a3e66ac79d9e84d34e4b1abae7
The caller is setting a default to 100, not BinaryClassificationMetrics.
Why not add a method? because of the complexity it introduces -- exactly
what your PR has to add. I would not make this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
