Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15085#discussion_r78658756
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -869,7 +876,20 @@ private[spark] class BlockManager(
blockInfoManager.unlock(blockId)
}
} else {
- blockInfoManager.removeBlock(blockId)
+ if (exceptionWasThrown) {
--- End diff --
I didn't combine it so that the `logWarning` wouldn't need to be
duplicated, but that's not a great rationale.
`removeBlockInternal` (which is used in both this `if` and `else` case now)
will handle releasing the lock (this happens in the
`blockInfoManager.removeBlock` call).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
