Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15085#discussion_r78674398
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -857,9 +862,11 @@ private[spark] class BlockManager(
val startTimeMs = System.currentTimeMillis
var blockWasSuccessfullyStored: Boolean = false
+ var exceptionWasThrown: Boolean = true
val result: Option[T] = try {
val res = putBody(putBlockInfo)
blockWasSuccessfullyStored = res.isEmpty
+ exceptionWasThrown = false
res
} finally {
if (blockWasSuccessfullyStored) {
--- End diff --
That said, I think we could simplify this by moving the non-error-case code
into the `try` block. Let me do that now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
