Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78909202
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -699,9 +703,10 @@ public boolean append(Object kbase, long koff, int
klen, Object vbase, long voff
// the key address instead of storing the absolute address of the
value, the key and value
// must be stored in the same memory page.
// (8 byte key length) (key) (value) (8 byte pointer to next value)
- final long recordLength = 8 + klen + vlen + 8;
+ int uaoSize = UnsafeAlignedOffset.getUaoSize();
+ final long recordLength = (2 * uaoSize) + klen + vlen + 8;
--- End diff --
Is the "8" here related to the alignment size and needs to be changed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
