Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78975745
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -46,6 +47,7 @@ private[columnar] trait CompressibleColumnBuilder[T <:
AtomicType]
this: NativeColumnBuilder[T] with WithCompressionSchemes =>
var compressionEncoders: Seq[Encoder[T]] = _
+ private val alignedArch = Set("sparc",
"sparcv9").contains(System.getProperty("os.arch"))
--- End diff --
Not sure what you mean. In
https://github.com/apache/spark/pull/14762#r77049945 I suggested the change you
made here, and that it be in a companion object. But here it's in the class.
I'm talking about companion objects as in "static methods". You don't need this
same flag value in every instance of the class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
