Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15082#discussion_r78927126
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/RowTest.scala ---
@@ -121,10 +121,6 @@ class RowTest extends FunSpec with Matchers {
externalRow should be theSameInstanceAs externalRow.copy()
}
- it("copy should return same ref for internal rows") {
--- End diff --
ah got it, but it's not true for internal row right? It can be mutable so
it's safe to remove this test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
