Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15082#discussion_r79029655
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/RowTest.scala ---
@@ -121,10 +121,6 @@ class RowTest extends FunSpec with Matchers {
externalRow should be theSameInstanceAs externalRow.copy()
}
- it("copy should return same ref for internal rows") {
--- End diff --
As discussed offline: I don't see the point of having an immutable
`GenericInternalRow` if we cannot guarantee its immutability. We could just
make every InternalRow a mutable one, and simplify the class structure in the
process. I am not sure if we should make that part of the current PR though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
