Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14926#discussion_r79035297
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -392,10 +397,70 @@ private[spark] class ExecutorAllocationManager(
}
/**
+ * Request the cluster manager to remove the given executors.
--- End diff --
This comment is weird. It's a private method, so there's no API to maintain.
The actual API that you're trying to maintain is `removeExecutor` below.
You could implement it by returning the list here and returning whether it's
empty from that method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
