Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14926#discussion_r79035412
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -392,10 +397,70 @@ private[spark] class ExecutorAllocationManager(
}
/**
+ * Request the cluster manager to remove the given executors.
+ * Return whether the request is acknowledged. Ideally we should be
returning the list of
+ * executors which were removed as the requested executors and the one's
actually removed can be
+ * different (CoarseGrainedSchedulerBackend can filter some executors).
To avoid breaking the API
+ * we continue to return a Boolean.
+ */
+ private def removeExecutors(executors: Seq[String]): Boolean =
synchronized {
+
--- End diff --
nit: no need for this empty line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
