Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15105#discussion_r79145091
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
    @@ -563,11 +580,16 @@ class Word2VecModel private[spark] (
           ind += 1
         }
     
    +    // NB: This code (and the documented behavior of findSynonyms
    --- End diff --
    
    Oh, is the problem that several words, including the word itself, may have 
1.0 similarity? and so the word itself may not sort as the top result among the 
1.0 results? Yeah, then the code below doesn't quite handle that case. (But 
below you wouldn't need the `take(num + 1)` now I think?)
    
    What about just ...
    
    ```
    val scored = wordList.zip(cosVec).toSeq.sortBy(-_._2)
    val filtered = wordOpt match {
      Some(word) => scored.take(num + 1).filter(p => word != p._1)
      None => scored
    }
    filtered.take(num).toArray
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to