Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14971#discussion_r79278095
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -378,6 +380,51 @@ private[hive] class HiveClientImpl(
val properties = Option(h.getParameters).map(_.asScala.toMap).orNull
+ val excludedTableProperties = Set(
+ // The following are hive-generated statistics fields. Currently,
only total_size and
+ // row_count are used to populate the dedicated field `stats`.
+ // TODO: stats should include all the other three fields.
+ StatsSetupConst.COLUMN_STATS_ACCURATE,
+ StatsSetupConst.NUM_FILES,
+ StatsSetupConst.NUM_PARTITIONS,
+ StatsSetupConst.ROW_COUNT,
+ StatsSetupConst.RAW_DATA_SIZE,
+ StatsSetupConst.TOTAL_SIZE,
+ // The property value of "comment" is moved to the dedicated field
"comment"
+ "comment",
+ // For EXTERNAL_TABLE, the table properties has a particular field
"EXTERNAL". This is added
+ // in the function toHiveTable.
+ "EXTERNAL"
+ )
+
+ val filteredProperties = properties.filterNot {
+ case (key, _) => excludedTableProperties.contains(key)
+ }
+ val comment = properties.get("comment")
+
+ val totalSize = properties.get(StatsSetupConst.TOTAL_SIZE).map(s =>
BigInt(s.toLong))
+ val rawDataSize =
properties.get(StatsSetupConst.RAW_DATA_SIZE).map(s => BigInt(s.toLong))
+ val rowCount = properties.get(StatsSetupConst.ROW_COUNT).map(s =>
BigInt(s.toLong)) match {
--- End diff --
Here, we also utilize Hive-generated row counts when users have not run
ANALYZE TABLE through Spark.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
