Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14971#discussion_r79281395
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -378,6 +380,47 @@ private[hive] class HiveClientImpl(
     
           val properties = Option(h.getParameters).map(_.asScala.toMap).orNull
     
    +      val excludedTableProperties = Set(
    +        // The following are hive-generated statistics fields. Currently, 
only total_size and
    +        // row_count are used to populate the dedicated field `stats`.
    +        // TODO: stats should include all the other three fields.
    +        StatsSetupConst.COLUMN_STATS_ACCURATE,
    +        StatsSetupConst.NUM_FILES,
    +        StatsSetupConst.NUM_PARTITIONS,
    +        StatsSetupConst.ROW_COUNT,
    +        StatsSetupConst.RAW_DATA_SIZE,
    --- End diff --
    
    ah I see. So our targets are:
    
    1. recognize hive statistics, i.e. we should set the `CatalogTable.stats` 
according to hive stats properties
    2. don't overwrite hive stats properties.
    3. SHOW CREATE TABLE shouldn't print hive stats properties.
    
    My proposal: In `HiveClientImpl`, set `CatalogTable.stats` by hive stats 
properties, and still keep them in table properties. In SHOW CREATE TABLE, hide 
the hive stats properties.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to