Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15054#discussion_r79340506
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -246,30 +246,42 @@ class SessionCatalog(
}
/**
- * Retrieve the metadata of an existing metastore table.
- * If no database is specified, assume the table is in the current
database.
- * If the specified table is not found in the database then a
[[NoSuchTableException]] is thrown.
+ * Retrieve the metadata of an existing temporary view.
+ * If the temporary view does not exist, a [[NoSuchTempViewException]]
is thrown.
*/
- def getTableMetadata(name: TableIdentifier): CatalogTable = {
- val db =
formatDatabaseName(name.database.getOrElse(getCurrentDatabase))
- val table = formatTableName(name.table)
- val tid = TableIdentifier(table)
- if (isTemporaryTable(name)) {
+ def getTempViewMetadata(name: String): CatalogTable = {
--- End diff --
let's move these 2 methods to the right section: `handles only temp view`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
