Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15054#discussion_r79340704
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala
 ---
    @@ -37,7 +38,9 @@ case class AnalyzeTableCommand(tableName: String, noscan: 
Boolean = true) extend
       override def run(sparkSession: SparkSession): Seq[Row] = {
         val sessionState = sparkSession.sessionState
         val tableIdent = sessionState.sqlParser.parseTableIdentifier(tableName)
    -    val relation = 
EliminateSubqueryAliases(sessionState.catalog.lookupRelation(tableIdent))
    +    val db = 
tableIdent.database.getOrElse(sessionState.catalog.getCurrentDatabase)
    +    val qualifiedName = TableIdentifier(tableIdent.table, Some(db))
    --- End diff --
    
    let's follow the existing convention and call it `tableIdentWithDB`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to