Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14988#discussion_r79557679
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
---
@@ -164,4 +164,28 @@ case class HiveTableScanExec(
}
override def output: Seq[Attribute] = attributes
+
+ override def sameResult(plan: SparkPlan): Boolean = plan match {
+ case other: HiveTableScanExec =>
+ val thisRequestedAttributes =
requestedAttributes.map(cleanExpression)
+ val otherRequestedAttributes =
other.requestedAttributes.map(cleanExpression)
--- End diff --
can you follow the existing workaround?
```
override def sameResult(plan: LogicalPlan): Boolean = {
plan.canonicalized match {
case LocalRelation(otherOutput, otherData) =>
otherOutput.map(_.dataType) == output.map(_.dataType) && otherData
== data
case _ => false
}
}
```
then we don't need to override `cleanExpression`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
