Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14988#discussion_r79568346
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
 ---
    @@ -164,4 +164,19 @@ case class HiveTableScanExec(
       }
     
       override def output: Seq[Attribute] = attributes
    +
    +  override def sameResult(plan: SparkPlan): Boolean = plan match {
    +    case other: HiveTableScanExec =>
    +      val thisPredicates = partitionPruningPred.map(cleanExpression)
    +      val otherPredicates = other.partitionPruningPred.map(cleanExpression)
    +
    +      val result = relation.sameResult(other.relation) &&
    +        output.length == other.output.length &&
    +          output.zip(other.output)
    +            .forall(p => p._1.name == p._2.name && p._1.dataType == 
p._2.dataType) &&
    --- End diff --
    
    does the name matter? I'm not quite sure, but `LogicalRelation` only checks 
data type 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to