Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15120#discussion_r79729632
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -143,4 +144,23 @@ package object config {
           .internal()
           .stringConf
           .createWithDefaultString("AES/CTR/NoPadding")
    +
    +  private[spark] val DRIVER_BIND_ADDRESS = 
ConfigBuilder("spark.driver.bindAddress")
    +    .doc("Address where to bind network listen sockets on the driver.")
    +    .stringConf
    +    .createWithDefault(Utils.localHostName())
    --- End diff --
    
    This is a broken change. If a user uses `spark.driver.host` to specify the 
bind address, it won't work now. Right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to